At present, you can create a bond, containing only underlying slaves that do not support LRO, and the bond will happily claim to support LRO, and allow LRO to be toggled on and off by ethtool. While things actually do function fine in the scenario, and this is merely cosmetic, its a bit misleading to users, and its something we can fix.
If we add NETIF_F_LRO to the NETIF_F_ONE_FOR_ALL flags in netdev_features.h, then netdev_features_increment() will only enable LRO if 1) its listed in the device's feature mask and 2) if there's actually a slave present that supports the feature. However, the bnx2x, ixgbe, netxen, qlcnic and s2io drivers all fail to report support for LRO in their vlan_features, which requires some minor fixups to these drivers to keep LRO working in cases where it should have been before this set. The mellanox mlx5 and cavium liquidio drivers already properly set the LRO flag in their vlan_features. Note: I've only tested explicitly with bnx2x, as well as some non-LRO hw, to confirm that: 1) if all slaves support LRO, the bond enables LRO 2) if some slaves support LRO, the bond enables LRO 3) if no slaves support LRO, the bond disables LRO This set was generated against net-next master, it applies to 4.2.0-rc6 with a bit of fuzz. Jarod Wilson (6): net/bonding: enable LRO if one device supports it ethernet/bnx2x: advertise LRO support in vlan_features ethernet/ixgbe: advertise LRO support in vlan_features ethernet/netxen: advertise LRO support in vlan_features ethernet/qlcnic: advertise LRO support in vlan_features ethernet/s2io: advertise what hw supports in vlan_features drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 ++- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++- drivers/net/ethernet/neterion/s2io.c | 1 + drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 4 +++- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 4 +++- include/linux/netdev_features.h | 3 ++- 6 files changed, 14 insertions(+), 5 deletions(-) CC: "David S. Miller" <[email protected]> CC: Ariel Elior <[email protected]> CC: Manish Chopra <[email protected]> CC: Rajesh Borundia <[email protected]> CC: Shahed Shaikh <[email protected]> CC: Sony Chacko <[email protected]> CC: [email protected] CC: Jiri Pirko <[email protected]> CC: Jon Mason <[email protected]> CC: Scott Feldman <[email protected]> CC: Tom Herbert <[email protected]> CC: Jeff Kirsher <[email protected]> CC: [email protected] CC: [email protected] -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
