Apologies for the duplicate, I accidentally Hit send before I finished the reply.
Punit Agrawal <[email protected]> writes: > [ adding Eduardo, Rui for their take on OF-thermal bindings ] > > Punit Agrawal <[email protected]> writes: > >> Hi Liviu, >> >> Thanks for having a look. >> >> Liviu Dudau <[email protected]> writes: >> >>> On Mon, Aug 03, 2015 at 04:22:58PM +0100, Punit Agrawal wrote: >>>> Setup a thermal zone driven by the SoC temperature sensor on Juno >>>> r0. Create passive trip points and bind them to cpufreq cooling >>>> devices that support the power extensions. >>> >>> Hi Punit, >>> >>>> >>>> Signed-off-by: Punit Agrawal <[email protected]> >>>> Cc: Rob Herring <[email protected]> >>>> Cc: Mark Rutland <[email protected]> >>>> Cc: Liviu Dudau <[email protected]> >>>> Cc: Sudeep Holla <[email protected]> >>>> --- >>>> arch/arm64/boot/dts/arm/juno.dts | 50 >>>> ++++++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 50 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/arm/juno.dts >>>> b/arch/arm64/boot/dts/arm/juno.dts >>>> index d2e67f3..664961c 100644 >>>> --- a/arch/arm64/boot/dts/arm/juno.dts >>>> +++ b/arch/arm64/boot/dts/arm/juno.dts >>>> @@ -9,6 +9,7 @@ >>>> /dts-v1/; >>>> >>>> #include <dt-bindings/interrupt-controller/arm-gic.h> >>>> +#include <dt-bindings/thermal/thermal.h> >>>> >>>> / { >>>> model = "ARM Juno development board (r0)"; >>>> @@ -90,6 +91,8 @@ >>>> next-level-cache = <&A57_L2>; >>>> clocks = <&scpi_dvfs 0>; >>>> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>; >>>> + #cooling-cells = <2>; >>>> + dynamic-power-coefficient = <530>; >>> >>> The Documentation/devicetree/bindings/thermal/thermal.txt document >>> describes two additional >>> required properties, cooling-min-state and cooling-max-state which are >>> missing here. >>> >> >> The bindings do suggest that the cooling-*-state are required but I >> couldn't find any code making use of this property. >> >> I'll send a patch with the next version making those properties >> optional. >> > > On second thoughts... > > The question about cooling-*-state has come up in another thread as > well [0]. I'll re-iterate the question for the thermal maintainers to > clarify. > > The cooling-{max,min}-state properties are marked mandatory in the > bindings but aren't used in the code anywhere. Can we drop those > properties from the binding documentation? Or at the least, make them > optional? > Let me know your preferred approach. I can include a fix in the next version. [0] http://thread.gmane.org/gmane.linux.ports.ppc.embedded/84512/focus=63339 > [...] > > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >> the body of a message to [email protected] >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
