Hi, I have compile tested on both x86 and arm64 on 4.1, but today will try with 4.2 and send updated patch. Thanks
-Brijesh ________________________________________ From: Corey Minyard [[email protected]] on behalf of Corey Minyard [[email protected]] Sent: Tuesday, August 25, 2015 6:59 AM To: yalin wang Cc: Singh, Brijeshkumar; [email protected]; [email protected] Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE On 08/24/2015 09:04 PM, yalin wang wrote: >> On Aug 25, 2015, at 08:48, Corey Minyard <[email protected]> wrote: >> >> Well, I should have compile tested first. On x86_64: >> >> >> CC [M] drivers/char/ipmi/ipmi_si_intf.o >> In file included from ../drivers/char/ipmi/ipmi_si_intf.c:42:0: >> ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: ‘ipmi_match’ >> undeclared here (not in a function) >> MODULE_DEVICE_TABLE(of, ipmi_match); >> ^ >> ../include/linux/module.h:223:21: note: in definition of macro >> ‘MODULE_DEVICE_TABLE’ >> extern const typeof(name) __mod_##type##__##name##_device_table \ >> ^ >> ../include/linux/module.h:223:27: error: >> ‘__mod_of__ipmi_match_device_table’ aliased to undefined symbol ‘ipmi_match’ >> extern const typeof(name) __mod_##type##__##name##_device_table \ >> ^ >> ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of macro >> ‘MODULE_DEVICE_TABLE’ >> MODULE_DEVICE_TABLE(of, ipmi_match); >> >> >> This has to compile on all arches. I'm not sure what is wrong, but I've >> removed the patch. >> >> -corey > it seems should be : > > MODULE_DEVICE_TABLE(of, of_ipmi_match); I actually already tried that, and it fails to compile on x86_64, too, with a different error. -corey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
