发自我的 iPhone
> 在 2015年9月2日，上午3:39，Arnaldo Carvalho de Melo <a...@redhat.com> 写道：
>
> Em Sat, Aug 29, 2015 at 04:21:55AM +0000, Wang Nan escreveu:
>> From: He Kuang <heku...@huawei.com>
>>
>> This patch moves filter.h from include/linux/kernel.h to
>
> I said that before: this is not moving anything, it is copying :-)
>
>> tools/include/linux/filter.h to enable other libraries use macros in
>> it, like libbpf which will be introduced by further patches. Currenty,
>> the moved filter.h only contains the useful macros needed by libbpf
>> for not introducing too much dependence.
>>
>> MANIFEST is also updated for 'make perf-*-src-pkg'.
>
> So, I did a:
>
> $ diff -u include/linux/filter.h tools/include/linux/filter.h
>
> And noticed these:
>
> -/* Endianess conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */
> +/* Endianness conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */
>
> -/* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg
> = imm32 */
> +/* Short form of mov based on type,
> + * BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32
> + */
>
> -/* Conditional jumps against registers, if (dst_reg 'op' src_reg) goto pc +
> off16 */
> +/* Conditional jumps against registers,
> + * if (dst_reg 'op' src_reg) goto pc + off16
> + */
>
> -/* Conditional jumps against immediates, if (dst_reg 'op' imm32) goto pc +
> off16 */
> +/* Conditional jumps against immediates,
> + * if (dst_reg 'op' imm32) goto pc + off16
> + */
>
> ------------------------------------------------------------------
>
I think these changes are made after we made this patch.
Thank you for checking it.
> Please refrain from doing that... I.e. spell checking is kinda useful,
> introducing gratuitous further drift from include/linux/FOO.h to
> tools/include/linux/FOO.h is not.
>
> So either resist the urge to do these stylistic changes or do those changes in
> include/linux/FOO.h and _then_ copy it to tools/include/linux/FOO.h.
>
> If the copy was already done, fix both, so that when we do that diff again, we
> can see what is really different in kernel and userspace copies and that maybe
> will help us spot things that aren't diverging over time.
>
> - Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
