On 5 September 2015 at 17:02, Robert Jarzmik <[email protected]> wrote: > Ezequiel Garcia <[email protected]> writes: > >> Robert, >> >> Just a couple of minor comments. >>> + dma_unmap_sg(info->dma_chan->device->dev, >>> + &info->sg, 1, info->dma_dir); >> >> Unneeded line breaking. > Indeed, for v2. > >>> + r = platform_get_resource(pdev, IORESOURCE_DMA, 1); >>> + if (r == NULL) { >>> + dev_err(&pdev->dev, >>> + "no resource defined for cmd DMA\n"); >>> + ret = -ENXIO; >>> + goto fail_disable_clk; >>> + } >>> + info->drcmr_cmd = r->start; >> >> AFAICS, you only do data DMA, so this command resource can go away. >> If you want to keep it for now and remove it as a follow up patch, >> that's fine. > Yeah, keep it in this patch, and change in a future patch (ie. keep current > behavior). > >> Other than this minor stuff: >> >> Reviewed-by: Ezequiel Garcia <[email protected]> >> Tested-by: Ezequiel Garcia <[email protected]> > Thanks, I'll add that in v2. > >> Tested on Armada 370 to make sure it doesn't cause any regressions. > Good. Was it on top of linux-next or linux master ? >
linux-next -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
