Hi Alexandre, On Fri, 11 Sep 2015 16:34:07 +0200 Alexandre Belloni <[email protected]> wrote:
> In the error path of at91_clk_register_system(), sys->irq is freed > unconditionally but it may not exist or be request at all. Not sure this is really needed since free_irq() seems to gracefully handle the case where the irq has not been previously requested [1] (it does not complain about invalid irq descriptors), but I guess this extra check cannot hurt. BTW, that's kinda weird that free_irq() accepts this case, but complains when you're trying to free a wrong (or already freed) shared irq handler [2]. Acked-by: Boris Brezillon <[email protected]> Best Regards, Boris [1]http://lxr.free-electrons.com/source/kernel/irq/manage.c#L1471 [2]http://lxr.free-electrons.com/source/kernel/irq/manage.c#L1377 > > Signed-off-by: Alexandre Belloni <[email protected]> > --- > drivers/clk/at91/clk-system.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/clk-system.c b/drivers/clk/at91/clk-system.c > index 58008b3e8bc1..3f5314344286 100644 > --- a/drivers/clk/at91/clk-system.c > +++ b/drivers/clk/at91/clk-system.c > @@ -138,7 +138,8 @@ at91_clk_register_system(struct at91_pmc *pmc, const char > *name, > > clk = clk_register(NULL, &sys->hw); > if (IS_ERR(clk)) { > - free_irq(sys->irq, sys); > + if (irq) > + free_irq(sys->irq, sys); > kfree(sys); > } > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
