On 09/22/2015 02:58 PM, Julia Lawall wrote:
>
> On Tue, 22 Sep 2015, Andrzej Hajda wrote:
>
>> kbuild/gcc uses -include option to include files and -I to provide paths for
>> #include <> directive. The same is true for spatch.
>>
>> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>
>> ---
>> scripts/coccicheck | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index bbf901a..6d84b05 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -30,7 +30,6 @@ FLAGS="$SPFLAGS --very-quiet"
>> # spatch only allows include directories with the syntax "-I include"
>> # while gcc also allows "-Iinclude" and "-include include"
>> COCCIINCLUDE=${LINUXINCLUDE//-I/-I }
>> -COCCIINCLUDE=${COCCIINCLUDE//-include/-I}
> I'm not sure of the meaning of the above notation, nor what is the
> intention. Coccinelle does have a --include option, but it doesn't mean
> the same thing as -I. It is a way to have a file be included that is not
> included according to the normal inclusion strategy. For example, if a.h
> includes b.h which includes c.h, and if one considers that c.h is really
> important for having the right type information, but one doesn't want the
> cost of including everything via --recursive-includes, then one could put
> --include c.h.
This option has the same meaning for gcc.
But the patch is incorrect. It should be:
COCCIINCLUDE=${COCCIINCLUDE// -include/ --include}
gcc option '-include' should be converted to spatch option '--include',
ie one minus should be added.
Regards
Andrzej
>
> julia
>
>
>> if [ "$C" = "1" -o "$C" = "2" ]; then
>> ONLINE=1
>> --
>> 1.9.1
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
