On 11/18, Alan Stern wrote: > > By the way, I think the fastpath for synchronize_srcu() should be safe, > now that you have added the memory barriers into srcu_read_lock() and > srcu_read_unlock(). You might as well try putting it in.
I still think the fastpath should do mb() unconditionally to be correct. > Although now that I look at it again, you have forgotten to put smp_mb() > after the atomic_inc() call and before the atomic_dec(). As I see it, currently we don't need this barrier because synchronize_srcu() does synchronize_sched() before reading ->hardluckref. But if we add the fastpath into synchronize_srcu() then yes, we need mb() after atomic_inc(). Unless I totally confused :) Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
