Hi, Rafael, > -----Original Message----- > From: [email protected] [mailto:linux-pm- > [email protected]] On Behalf Of Rafael J. Wysocki > Sent: Sunday, September 27, 2015 9:30 PM > To: Chen, Yu C > Cc: Wysocki, Rafael J; [email protected]; Zhang, Rui; Brown, Len; > linux- > [email protected]; [email protected] > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before > suspend-to-idle > > On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote: > > Hi, Rafael, > > > > > -----Original Message----- > > > From: [email protected] [mailto:linux-pm- > > > [email protected]] On Behalf Of Rafael J. Wysocki > > > Sent: Friday, September 25, 2015 9:57 PM > > > To: Chen, Yu C > > > Cc: Wysocki, Rafael J; [email protected]; Zhang, Rui; Brown, > > > Len; linux- [email protected]; [email protected] > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq > > > setting before suspend-to-idle > > > > > > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote: > > > > Hi,Rafael, thanks a lot for your review, will resend v2 version. > > > > > > > > > -----Original Message----- > > > > > From: Rafael J. Wysocki [mailto:[email protected]] > > > > > Sent: Friday, September 25, 2015 9:24 AM > > > > > To: Chen, Yu C > > > > > Cc: Wysocki, Rafael J; [email protected]; Zhang, Rui; > > > > > Brown, Len; linux- [email protected]; > > > > > [email protected] > > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq > > > > > setting before suspend-to-idle > > > > > > > > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote: > > > > > > But I'd rather define a global acpi_irq variable, store irq in it > > > and access it directly from acpi_freeze_prepare(). And it doesn't > > > have to depend on CONFIG_SUSPEND as it is just the IRQ number > actually used by ACPI. > > > > > OK, I've convert it to a global variable acpi_inuse_irq. > > Why do you need the "inuse" part? Why is acpi_irq not sufficient? Because the name of acpi_irq is already used by acpi irq handler at drivers/acpi/osl.c: request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)
Thanks Yu
