* Linus Torvalds <[EMAIL PROTECTED]> wrote:

> -     if (!strcmp(buf,"keep"))
> +     if (!strncmp(buf,"keep", 4)) {
>               keep_early = 1;
> -
> -     if (!strncmp(buf, "serial", 6)) {
> +     } else if (!strncmp(buf, "serial", 6)) {
>               early_serial_init(buf + 6);
>               early_console = &early_serial_console;

nope, that doesnt work, because the function call is a one-time thing 
via the early_console_initialized flag. Nor does this keep compatibility 
with the 2.6.18 API, my existing boot-entries:

        root (hd0,4)
        kernel /boot/bzImage-x64 root=/dev/hda5 \
        earlyprintk=serial,ttyS0,115200,keep console=ttyS0,115200 console=tty

stopped working.

I agree that the parameter parsing here is a bit hacky, but my patch 
restores the original behavior, so i think that's the best option for 
now.

        Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to