On Wed, 7 Oct 2015, Maurizio Lombardi wrote:
Hi, On 10/07/2015 03:11 PM, Arnd Bergmann wrote:- memset(&npiv_tbl, 0, sizeof(npiv_tbl)); - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl)) + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL); + if (!npiv_tbl) goto done;If kzalloc() fails perhaps the function should return -ENOMEM, not zero.
The enablement of the fcoe interface can still proceed if this particular allocation fails so returning 0 would be appropriate here.
This patch looks good to me.
Regards, Maurizio Lombardi
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
