On Sun, Sep 27, 2015 at 08:37:58PM +0200, Rabin Vincent wrote: > Pass CFLAGS and LDFLAGS to the libiberty compile line to make the > detection work when using a cross compiler. > > Otherwise perf fails to link even though BFD is detected. > > ... libbfd: [ on ] > > LINK perf > libbfd.a(bfd.o): In function `bfd_errmsg': > bfd.c:(.text+0x168): undefined reference to `xstrerror' > bbfd.a(opncls.o): In function `_bfd_new_bfd': > opncls.c:(.text+0xe8): undefined reference to `objalloc_create'
We have FEATURE_CHECK_CFLAGS/FEATURE_CHECK_LDFLAGS variables to pass CFLAGS/LDFLAGS to feature detection build Could you also be more specific on what is missing to make the libiberty check compile? thanks, jirka > ... > > Signed-off-by: Rabin Vincent <[email protected]> > --- > tools/build/feature/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index e43a297..cea04ce9 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -132,10 +132,10 @@ test-libbfd.bin: > $(BUILD) -DPACKAGE='"perf"' -lbfd -lz -liberty -ldl > > test-liberty.bin: > - $(CC) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' > -lbfd -ldl -liberty > + $(CC) $(CFLAGS) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c > -DPACKAGE='"perf"' $(LDFLAGS) -lbfd -ldl -liberty > > test-liberty-z.bin: > - $(CC) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' > -lbfd -ldl -liberty -lz > + $(CC) $(CFLAGS) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c > -DPACKAGE='"perf"' $(LDFLAGS) -lbfd -ldl -liberty -lz > > test-cplus-demangle.bin: > $(BUILD) -liberty > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
