On Wed, Nov 29, 2006 at 03:05:44PM -0800, Andrew Morton wrote: > btw, I don't think anyone promised that __test_and_set_bit is atomic wrt > interrupts on all architectures. Is OK for x86.
Correct. The generic version found in include/asm-generic/bitops/non-atomic.h is not interrupt safe: /** * __test_and_set_bit - Set a bit and return its old value * @nr: Bit to set * @addr: Address to count from * * This operation is non-atomic and can be reordered. * If two examples of this operation race, one can appear to succeed * but actually fail. You must protect multiple accesses with a lock. */ -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
