So the patch will be refined to remove the comment as follows. Any else
comments?
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
.resources = axp288_fuel_gauge_resources,
},
{
+ .name = "axp20x-pek",
+ .num_resources = ARRAY_SIZE(axp288_power_button_resources),
+ .resources = axp288_power_button_resources,
+ },
+ {
.name = "axp288_pmic_acpi",
},
};
On 10/14/2015 15:08, Lee Jones wrote:
> On Tue, 13 Oct 2015, Yang, Fei wrote:
>
>>>> static struct resource axp288_fuel_gauge_resources[] = {
>>>> {
>>>> .start = AXP288_IRQ_QWBTU,
>>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>>>> .resources = axp288_fuel_gauge_resources,
>>>> },
>>>> {
>>>> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>>>
>>> Doesn't this change insinuate that?
>>>
>>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this
>>> structure right?
>>
>> Are you suggesting to remove the comment? Just want to make sure I
>> understand you correctly.
>
> I am.
>
>>>> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
>>>> + .resources = axp288_power_button_resources,
>>>> + },
>>>> + {
>>>> .name = "axp288_pmic_acpi",
>>>> },
>>>> };
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
