On Tue, Oct 06 2015, Rasmus Villemoes <[email protected]> wrote:
> On Mon, Oct 05 2015, Bart Van Assche <[email protected]> wrote: > >> On 10/05/15 02:26, Rasmus Villemoes wrote: >>> - {0x041A, "Logical unit not ready, start stop unit command in " >>> - "progress"}, >>> - {0x041B, "Logical unit not ready, sanitize in progress"}, >>> - {0x041C, "Logical unit not ready, additional power use not yet " >>> - "granted"}, >> >> Please convert these multi-line strings into single line string >> constants such that users can look up these easily with grep. > > I can certainly do that, but I'd prefer to do it in a separate patch. I > really want to keep this as mechanical as possible. > >>> + >>> +SENSE_CODE(0, NULL) >> >> The above looks confusing to me. Please leave this out and add { 0, >> NULL } at the end of the additional[] array instead. > > OK, I agree that that would have been cleaner. However, the sentinel > entry is removed in 2/2 (since we loop using ARRAY_SIZE instead of > checking for the sentinel). Let me know if you want me to resend the > 1600 line monster anyway with this addressed. Should I resend, or can these be picked up as-is? I can easily send a 3/2 making the strings more greppable. Thanks, Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
