On Wed, Oct 18, 2023 at 11:27 AM Linus Torvalds <[email protected]> wrote: > > On Wed, 18 Oct 2023 at 10:14, Jeff Xu <[email protected]> wrote: > This is simply not up for discussion. Any flag for "ignore sealing" is wrong. > > We do have one special "unmap" case, namely "unmap_vmas()' called at > last mmput() -> __mmput() -> exit_mmap(). > > And yes, that is called at munmap() time too, but that's after the > point of no return after we've already removed the vma's from the VM > lists. So it's long after any error cases have been checked. > Ah. I see. I didn't know there was no legit case, which is what I worried about before. this flag can be removed.
- [RFC PATCH v2 2/8] mseal: Wire up mseal syscall jeffxu
- [RFC PATCH v2 1/8] mseal: Add mseal(2) syscall. jeffxu
- Re: [RFC PATCH v2 1/8] mseal: Add mseal(2) sysca... Randy Dunlap
- [RFC PATCH v2 4/8] mseal: Check seal flag for mprotec... jeffxu
- [RFC PATCH v2 3/8] mseal: add can_modify_mm and can_m... jeffxu
- [RFC PATCH v2 5/8] mseal: Check seal flag for munmap(... jeffxu
- Re: [RFC PATCH v2 5/8] mseal: Check seal flag fo... Linus Torvalds
- Re: [RFC PATCH v2 5/8] mseal: Check seal fla... Jeff Xu
- Re: [RFC PATCH v2 5/8] mseal: Check seal... Jeff Xu
- Re: [RFC PATCH v2 5/8] mseal: Check ... Linus Torvalds
- Re: [RFC PATCH v2 5/8] mseal: C... Jeff Xu
- [RFC PATCH v2 7/8] mseal:Check seal flag for mmap(2) jeffxu
- Re: [RFC PATCH v2 7/8] mseal:Check seal flag for... Linus Torvalds
- Re: [RFC PATCH v2 7/8] mseal:Check seal flag... Linus Torvalds
- Re: [RFC PATCH v2 7/8] mseal:Check seal ... Jeff Xu
- Re: [RFC PATCH v2 7/8] mseal:Check seal ... Stephen Röttger
- [RFC PATCH v2 6/8] mseal: Check seal flag for mremap(... jeffxu
- Re: [RFC PATCH v2 6/8] mseal: Check seal flag fo... Muhammad Usama Anjum
- [RFC PATCH v2 8/8] selftest mm/mseal mprotect/munmap/... jeffxu
- Re: [RFC PATCH v2 8/8] selftest mm/mseal mprotec... Muhammad Usama Anjum
- Re: [RFC PATCH v2 8/8] selftest mm/mseal mpr... Peter Zijlstra
