Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on c8613be119892ccceffbc550b9b9d7d68b995c9e]

url:    
https://github.com/intel-lab-lkp/linux/commits/davidgow-google-com/kunit-Add-APIs-for-managing-devices/20231205-153349
base:   c8613be119892ccceffbc550b9b9d7d68b995c9e
patch link:    
https://lore.kernel.org/r/20231205-kunit_bus-v1-1-635036d3bc13%40google.com
patch subject: [PATCH 1/4] kunit: Add APIs for managing devices
config: x86_64-randconfig-122-20231205 
(https://download.01.org/0day-ci/archive/20231205/[email protected]/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git 
ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20231205/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/[email protected]/

sparse warnings: (new ones prefixed by >>)
>> lib/kunit/device.c:100:21: sparse: sparse: symbol 
>> '__kunit_device_register_internal' was not declared. Should it be static?

vim +/__kunit_device_register_internal +100 lib/kunit/device.c

    99  
 > 100  struct kunit_device *__kunit_device_register_internal(struct kunit 
 > *test,
   101                                                        const char *name,
   102                                                        struct 
device_driver *drv)
   103  {
   104          struct kunit_device *kunit_dev;
   105          int err = -ENOMEM;
   106  
   107          kunit_dev = kzalloc(sizeof(struct kunit_device), GFP_KERNEL);
   108          if (!kunit_dev)
   109                  return ERR_PTR(err);
   110  
   111          kunit_dev->owner = test;
   112  
   113          err = dev_set_name(&kunit_dev->dev, "%s.%s", test->name, name);
   114          if (err) {
   115                  kfree(kunit_dev);
   116                  return ERR_PTR(err);
   117          }
   118  
   119          /* Set the expected driver pointer, so we match. */
   120          kunit_dev->driver = drv;
   121  
   122          kunit_dev->dev.release = kunit_device_release;
   123          kunit_dev->dev.bus = &kunit_bus_type;
   124          kunit_dev->dev.parent = &kunit_bus;
   125  
   126          err = device_register(&kunit_dev->dev);
   127          if (err) {
   128                  put_device(&kunit_dev->dev);
   129                  return ERR_PTR(err);
   130          }
   131  
   132          kunit_add_action(test, device_unregister_wrapper, 
&kunit_dev->dev);
   133  
   134          return kunit_dev;
   135  }
   136  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to