On Tue, 5 Dec 2023 at 06:19, Rae Moar <[email protected]> wrote: > > Add is_init test attribute of type bool. Add to_string, get, and filter > methods to lib/kunit/attributes.c. > > Mark each of the tests in the init section with the is_init=true attribute. > > Add is_init to the attributes documentation. > > Signed-off-by: Rae Moar <[email protected]> > ---
Would it be possible to not have this in kunit_attributes? I know it's required for the run-after-boot stuff later, but I'd love this to be (a) just generated at runtime, or (b) stored only at a suite or suite-set level. It seems like a bit of a waste to store this per-test-case, and to have it potentially accessible or overwritable by users. Otherwise, this looks good (and I appreciate the automatic setting of this when merging the suite sets. Maybe if we always kept the init suites in a separate set, we could just use pointer comparisons to generate this; otherwise let's make this a suite-level-only attribute (inherited by tests). -- David
smime.p7s
Description: S/MIME Cryptographic Signature
