On 12/15/23 06:28, Ryan Roberts wrote:
...
I've kept all the existing "pretty" output and results summary as is, it just
gets a hash in front of it when TAP is enabled.

so this:

-----------------------
running ./hugepage-mmap
-----------------------
Returned address is 0xffff89e00000
First hex is 0
First hex is 3020100
[PASS]
SUMMARY: PASS=1 SKIP=0 FAIL=0

becomes this:

TAP version 13
# -----------------------
# running ./hugepage-mmap
# -----------------------
# Returned address is 0xffff89e00000
# First hex is 0
# First hex is 3020100
# [PASS]
ok 1 hugepage-mmap
# SUMMARY: PASS=1 SKIP=0 FAIL=0
1..1

If you think the latter is ofensive, then I can do the wrapping as you suggest.

I applied this and ran the tests, all while carefully reminding myself
to "think like a human". :) And from that perspective, to me, the output
is effectively the same: the leading '#' characters do not really change
anything, from a readability point of view.

So IMHO you're on perfectly solid ground, if you just switch over
directly to this format.

Tested-by: John Hubbard <[email protected]>


thanks,
--
John Hubbard
NVIDIA


Reply via email to