> From: Yang, Weijiang <[email protected]>
> Sent: Friday, December 22, 2023 11:56 AM
> > +
> > +   xa_for_each(&domain->iommu_array, i, info) {
> > +           nested_flush_pasid_iotlb(info->iommu, domain, addr,
> npages, 0);
> > +
> > +           if (domain->has_iotlb_device)
> > +                   continue;
> 
> Shouldn't this be if (!domain->has_iotlb_device)?

yes that is wrong.

actually it's weird to put domain check in a loop of domain->iommu_array.

that check along with devtlb flush should be done out of that loop.

Reply via email to