On 2023/12/22 11:39, Tian, Kevin wrote:
From: Liu, Yi L <[email protected]>
Sent: Thursday, December 21, 2023 11:40 PM
+
+
+               if ((inv.flags & IOMMU_TEST_INVALIDATE_FLAG_ALL) &&
+                   (inv.flags &
IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR)) {
+                       rc = -EINVAL;
+                       break;
+               }
+

a  nit. is there a reason why the two flags can not be set together?

in concept a mock iommu error could occur in either invalidate-one
or invalidate-all.

I see. I'm ok to relax this check and remove the selftest case as well.

otherwise,

Reviewed-by: Kevin Tian <[email protected]>

--
Regards,
Yi Liu

Reply via email to