[AMD Official Use Only - General] Hi Petkov:
> -----Original Message----- > From: Borislav Petkov <[email protected]> > Sent: Tuesday, January 9, 2024 6:45 PM > To: Meng, Li (Jassmine) <[email protected]> > Cc: Rafael J . Wysocki <[email protected]>; Huang, Ray > <[email protected]>; [email protected]; linux- > [email protected]; [email protected]; [email protected]; Shuah > Khan <[email protected]>; [email protected]; > Fontenot, Nathan <[email protected]>; Sharma, Deepak > <[email protected]>; Deucher, Alexander > <[email protected]>; Limonciello, Mario > <[email protected]>; Huang, Shimmer > <[email protected]>; Yuan, Perry <[email protected]>; Du, > Xiaojian <[email protected]>; Viresh Kumar <[email protected]>; > Oleksandr Natalenko <[email protected]> > Subject: Re: [PATCH V12 1/7] x86: Drop CPU_SUP_INTEL from > SCHED_MC_PRIO for the expansion. > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On Tue, Dec 05, 2023 at 02:35:31PM +0800, Meng Li wrote: > > amd-pstate driver also uses SCHED_MC_PRIO, so decouple the > requirement > > of CPU_SUP_INTEL from the dependencies to allow compilation in kernels > > without Intel CPU support. > > > > Tested-by: Oleksandr Natalenko <[email protected]> > > Reviewed-by: Mario Limonciello <[email protected]> > > Reviewed-by: Huang Rui <[email protected]> > > Reviewed-by: Perry Yuan <[email protected]> > > Signed-off-by: Meng Li <[email protected]> > > --- > > arch/x86/Kconfig | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index > > 3762f41bb092..3e57773f946a 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -1054,8 +1054,9 @@ config SCHED_MC > > > > config SCHED_MC_PRIO > > bool "CPU core priorities scheduler support" > > - depends on SCHED_MC && CPU_SUP_INTEL > > - select X86_INTEL_PSTATE > > + depends on SCHED_MC > > + select X86_INTEL_PSTATE if CPU_SUP_INTEL > > + select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI > > select CPU_FREQ > > default y > > help > > -- > > I was gonna ask why the selects but apparently mingo wants > SCHED_MC_PRIO to be selectable easier: > > 0a21fc1214a2 ("sched/x86: Make CONFIG_SCHED_MC_PRIO=y easier to > enable") > [Meng, Li (Jassmine)] Thank you for your feedback. The reason why I added the selects is just to distinguish different pstate drivers. These two drivers cannot be supported simultaneously in the same project. > So, > > Acked-by: Borislav Petkov (AMD) <[email protected]> > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
