Hi Dmitry, First, thank you for submitting this very helpful set of tcp-ao selftests!
>-----Original Message----- >From: Dmitry Safonov <[email protected]> >Sent: Thursday, December 14, 2023 9:36 PM >To: Shuah Khan <[email protected]>; David Ahern <[email protected]>; >David S. Miller <[email protected]>; Eric Dumazet ><[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni ><[email protected]> >Cc: Dmitry Safonov <[email protected]>; Salam Noureddine ><[email protected]>; Bob Gilligan <[email protected]>; linux- >[email protected]; [email protected]; >[email protected]; Dmitry Safonov <[email protected]> >Subject: [PATCH 01/12] selftests/net: Add TCP-AO library > >Provide functions to create selftests dedicated to TCP-AO. >They can run in parallel, as they use temporary net namespaces. >They can be very specific to the feature being tested. >This will allow to create a lot of TCP-AO tests, without complicating >one binary with many --options and to create scenarios, that are >hard to put in bash script that uses one binary. > >Signed-off-by: Dmitry Safonov <[email protected]> >+ key_dump[0].nkeys = nr_keys; >+ key_dump[0].get_all = 1; >+ key_dump[0].get_all = 1; Duplicate assignment of get_all. >+ err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS, >+ key_dump, &key_dump_sz); >+ if (err) { >+ free(key_dump); >+ return -errno; >+ } >+} >+ >+const struct sockaddr_in6 addr_any6 = { >+ .sin6_family = AF_INET6, >+}; >+ >+const struct sockaddr_in addr_any4 = { >+ .sin_family = AF_INET, >+}; > >-- >2.43.0 Mohammad
