Paolo Abeni <[email protected]> writes: > The big_tcp test-case requires a few kernel knobs currently > not specified in the net selftests config, causing the > following failure: > > # selftests: net: big_tcp.sh > # Error: Failed to load TC action module. > # We have an error talking to the kernel > ... > # Testing for BIG TCP: > # CLI GSO | GW GRO | GW GSO | SER GRO > # ./big_tcp.sh: line 107: test: !=: unary operator expected > ... > # on on on on : [FAIL_on_link1] > > Add the missing configs > > Fixes: 6bb382bcf742 ("selftests: add a selftest for big tcp") > Signed-off-by: Paolo Abeni <[email protected]> > ---
Thanks for the fix. Maybe we should also add the config for NET_ACT_CT since we will invoke it on setup. I guess there's some dependency that must be pulling it in for us already so we don't explicitly call for it, but we do require it in setup() if I understand correctly. I don't think it should hold up this patch though. Acked-by: Aaron Conole <[email protected]>
