Hi,
On 2/14/24 15:36, Elizabeth Figura wrote:
> ntsync uses a misc device as the simplest and least intrusive uAPI interface.
>
> Each file description on the device represents an isolated NT instance,
> intended
> to correspond to a single NT virtual machine.
>
> Signed-off-by: Elizabeth Figura <[email protected]>
> ---
> drivers/misc/Kconfig | 9 ++++++++
> drivers/misc/Makefile | 1 +
> drivers/misc/ntsync.c | 52 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 62 insertions(+)
> create mode 100644 drivers/misc/ntsync.c
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 4fb291f0bf7c..bdd8a71bd853 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -504,6 +504,15 @@ config OPEN_DICE
> measured boot flow. Userspace can use CDIs for remote attestation
> and sealing.
>
> +config NTSYNC
> + tristate "NT synchronization primitive emulation"
> + help
> + This module provides kernel support for emulation of Windows NT
> + synchronization primitives. It is not a hardware driver.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called ntsync.
> +
> If unsure, say N.
It looks like the "If unsure" line belongs to the OPEN_DICE kconfig entry
above here. If you want one for NTSYNC, please add one.
>
> config VCPU_STALL_DETECTOR
> diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
> new file mode 100644
> index 000000000000..e4969ef90722
> --- /dev/null
> +++ b/drivers/misc/ntsync.c
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * ntsync.c - Kernel driver for NT synchronization primitives
> + *
> + * Copyright (C) 2024 Elizabeth Figura
It would be nice to have your email address above...
> + */
> +
> +
> +MODULE_AUTHOR("Elizabeth Figura");
but at least please add it in MODULE_AUTHOR(). Yes it's optional, but
roughly 7900 of 10400 entries do include it (according to my rough
grepping).
Yes, I know that it's in MAINTAINERS.
> +MODULE_DESCRIPTION("Kernel driver for NT synchronization primitives");
> +MODULE_LICENSE("GPL");
thanks.
--
#Randy
