The netdev CI runs in a VM and captures serial, so stdout and
stderr get combined. Because there's a missing new line in
stderr the test ends up corrupting KTAP:

  # Successok 1 selftests: net: reuseaddr_conflict

which should have been:

  # Success
  ok 1 selftests: net: reuseaddr_conflict

Fixes: 422d8dc6fd3a ("selftest: add a reuseaddr test")
Signed-off-by: Jakub Kicinski <[email protected]>
---
Low risk and seems worth backporting to stable, hence the fixes tag.

CC: [email protected]
CC: [email protected]
CC: [email protected]
---
 tools/testing/selftests/net/reuseaddr_conflict.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/reuseaddr_conflict.c 
b/tools/testing/selftests/net/reuseaddr_conflict.c
index 7c5b12664b03..bfb07dc49518 100644
--- a/tools/testing/selftests/net/reuseaddr_conflict.c
+++ b/tools/testing/selftests/net/reuseaddr_conflict.c
@@ -109,6 +109,6 @@ int main(void)
        fd1 = open_port(0, 1);
        if (fd1 >= 0)
                error(1, 0, "Was allowed to create an ipv4 reuseport on an 
already bound non-reuseport socket with no ipv6");
-       fprintf(stderr, "Success");
+       fprintf(stderr, "Success\n");
        return 0;
 }
-- 
2.44.0


Reply via email to