On Wed, Apr 10, 2024 at 4:26 PM John Stultz <[email protected]> wrote: > > After commit 6d029c25b71f ("selftests/timers/posix_timers: > Reimplement check_timer_distribution()") I started seeing the > following warning building with an older gcc: > > posix_timers.c:250:2: warning: format not a string literal and no format > arguments [-Wformat-security] > 250 | ksft_print_msg(errmsg); > | ^~~~~~~~~~~~~~ > > Fix this up by changing it to ksft_print_msg("%s", errmsg) > > Cc: Shuah Khan <[email protected]> > Cc: Anna-Maria Behnsen <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Stephen Boyd <[email protected]> > Cc: Nathan Chancellor <[email protected]> > Cc: Nick Desaulniers <[email protected]> > Cc: Bill Wendling <[email protected]> > Cc: Justin Stitt <[email protected]> > Cc: Oleg Nesterov <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Edward Liaw <[email protected]> > Cc: Carlos Llamas <[email protected]> > Cc: [email protected] > Cc: [email protected] > Fixes: 6d029c25b71f ("selftests/timers/posix_timers: Reimplement > check_timer_distribution()") > Signed-off-by: John Stultz <[email protected]>
Yep, makes sense. Acked-by: Justin Stitt <[email protected]> > --- > tools/testing/selftests/timers/posix_timers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/timers/posix_timers.c > b/tools/testing/selftests/timers/posix_timers.c > index d86a0e00711e..348f47176e0a 100644 > --- a/tools/testing/selftests/timers/posix_timers.c > +++ b/tools/testing/selftests/timers/posix_timers.c > @@ -247,7 +247,7 @@ static int check_timer_distribution(void) > ksft_test_result_skip("check signal distribution (old > kernel)\n"); > return 0; > err: > - ksft_print_msg(errmsg); > + ksft_print_msg("%s", errmsg); > return -1; > } > > -- > 2.44.0.478.gd926399ef9-goog >
