On 4/23/24 12:39 PM, Kunwu Chan wrote: > There is a 'malloc' call in test_vmx_nested_state function, which can > be unsuccessful. This patch will add the malloc failure checking > to avoid possible null dereference and give more information > about test fail reasons. LGTM
Reviewed-by: Muhammad Usama Anjum <[email protected]> > > Signed-off-by: Kunwu Chan <[email protected]> > --- > tools/testing/selftests/kvm/x86_64/vmx_set_nested_state_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kvm/x86_64/vmx_set_nested_state_test.c > b/tools/testing/selftests/kvm/x86_64/vmx_set_nested_state_test.c > index 67a62a5a8895..18afc2000a74 100644 > --- a/tools/testing/selftests/kvm/x86_64/vmx_set_nested_state_test.c > +++ b/tools/testing/selftests/kvm/x86_64/vmx_set_nested_state_test.c > @@ -91,6 +91,7 @@ void test_vmx_nested_state(struct kvm_vcpu *vcpu) > const int state_sz = sizeof(struct kvm_nested_state) + getpagesize(); > struct kvm_nested_state *state = > (struct kvm_nested_state *)malloc(state_sz); > + TEST_ASSERT(state, "-ENOMEM when allocating kvm state"); > > /* The format must be set to 0. 0 for VMX, 1 for SVM. */ > set_default_vmx_state(state, state_sz); -- BR, Muhammad Usama Anjum
