From: Geliang Tang <[email protected]>

The strdup() function returns a pointer to a new string which is a
duplicate of the string "ptr". Memory for the new string is obtained
with malloc(), and need to be freed with free().

This patch adds these missing "free(ptr)" in check_whitelist() and
check_blacklist() to avoid memory leaks in test_sockmap.c.

Signed-off-by: Geliang Tang <[email protected]>
---
 tools/testing/selftests/bpf/test_sockmap.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/test_sockmap.c 
b/tools/testing/selftests/bpf/test_sockmap.c
index 43612de44fbf..92752f5eeded 100644
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -1887,10 +1887,13 @@ static int check_whitelist(struct _test *t, struct 
sockmap_options *opt)
        while (entry) {
                if ((opt->prepend && strstr(opt->prepend, entry) != 0) ||
                    strstr(opt->map, entry) != 0 ||
-                   strstr(t->title, entry) != 0)
+                   strstr(t->title, entry) != 0) {
+                       free(ptr);
                        return 0;
+               }
                entry = strtok(NULL, ",");
        }
+       free(ptr);
        return -EINVAL;
 }
 
@@ -1907,10 +1910,13 @@ static int check_blacklist(struct _test *t, struct 
sockmap_options *opt)
        while (entry) {
                if ((opt->prepend && strstr(opt->prepend, entry) != 0) ||
                    strstr(opt->map, entry) != 0 ||
-                   strstr(t->title, entry) != 0)
+                   strstr(t->title, entry) != 0) {
+                       free(ptr);
                        return 0;
+               }
                entry = strtok(NULL, ",");
        }
+       free(ptr);
        return -EINVAL;
 }
 
-- 
2.40.1


Reply via email to