Jakub Kicinski wrote: > On slow machines the SND timestamp sometimes doesn't arrive before > we quit. The test only waits as long as the packet delay, so it's > easy for a race condition to happen. > > Double the wait but do a bit of polling, once the SND timestamp > arrives there's no point to wait any longer. > > This fixes the "TXTIME abs" failures on debug kernels, like: > > Case ICMPv4 - TXTIME abs returned '', expected 'OK' > > Signed-off-by: Jakub Kicinski <[email protected]>
Reviewed-by: Willem de Bruijn <[email protected]> > diff --git a/tools/testing/selftests/net/cmsg_sender.c > b/tools/testing/selftests/net/cmsg_sender.c > index c79e65581dc3..f25268504937 100644 > --- a/tools/testing/selftests/net/cmsg_sender.c > +++ b/tools/testing/selftests/net/cmsg_sender.c > @@ -333,16 +333,17 @@ static const char *cs_ts_info2str(unsigned int info) > return "unknown"; > } > > -static void > +static unsigned long > cs_read_cmsg(int fd, struct msghdr *msg, char *cbuf, size_t cbuf_sz) > { > struct sock_extended_err *see; > struct scm_timestamping *ts; > + unsigned int ts_seen = 0; nit: mixing unsigned long and unsigned int
