There is no need to add the name to ns_list again if the netns already
recoreded.

Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Signed-off-by: Hangbin Liu <[email protected]>
---
 tools/testing/selftests/net/lib.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/lib.sh 
b/tools/testing/selftests/net/lib.sh
index f9fe182dfbd4..56a9454b7ba3 100644
--- a/tools/testing/selftests/net/lib.sh
+++ b/tools/testing/selftests/net/lib.sh
@@ -73,15 +73,17 @@ setup_ns()
        local ns=""
        local ns_name=""
        local ns_list=""
+       local ns_exist=
        for ns_name in "$@"; do
                # Some test may setup/remove same netns multi times
                if unset ${ns_name} 2> /dev/null; then
                        ns="${ns_name,,}-$(mktemp -u XXXXXX)"
                        eval readonly ${ns_name}="$ns"
+                       ns_exist=false
                else
                        eval ns='$'${ns_name}
                        cleanup_ns "$ns"
-
+                       ns_exist=true
                fi
 
                if ! ip netns add "$ns"; then
@@ -90,7 +92,7 @@ setup_ns()
                        return $ksft_skip
                fi
                ip -n "$ns" link set lo up
-               ns_list="$ns_list $ns"
+               ! $ns_exist && ns_list="$ns_list $ns"
        done
        NS_LIST="$NS_LIST $ns_list"
 }
-- 
2.43.0


Reply via email to