Re: [PATCH v5 08/16] riscv: add ISA parsing for Zca, Zcf, Zcd and Zcb

[Conor Dooley]

On Fri, May 17, 2024 at 04:52:48PM +0200, Clément Léger wrote:

> +static int riscv_ext_zca_depends(const struct riscv_isa_ext_data *data,
> +                              const unsigned long *isa_bitmap)
> +{
> +     return __riscv_isa_extension_available(isa_bitmap, RISCV_ISA_EXT_ZCA) ? 
> 0 : -EPROBE_DEFER;
> +}
> +static int riscv_ext_zcd_validate(const struct riscv_isa_ext_data *data,
> +                               const unsigned long *isa_bitmap)
> +{
> +     return __riscv_isa_extension_available(isa_bitmap, RISCV_ISA_EXT_ZCA) &&
> +            __riscv_isa_extension_available(isa_bitmap, RISCV_ISA_EXT_d) ? 0 
> : -EPROBE_DEFER;
> +}

Could you write the logic in these out normally please? I think they'd
be more understandable (particular this second one) broken down and with
early return.

Otherwise,
Reviewed-by: Conor Dooley <conor.doo...@microchip.com>

Cheers,
Conor.

signature.asc
Description: PGP signature