Re: [PATCH bpf-next v6 6/9] selftests/bpf: Use start_server_str in sk_lookup

[Martin KaFai Lau]

On 6/28/24 6:20 PM, Geliang Tang wrote:
+static int make_server(int sotype, const char *ip, int port,
+                      struct bpf_program *reuseport_prog)
+{
+       struct cb_opts cb_opts = {
+               .family = is_ipv6(ip) ? AF_INET6 : AF_INET,
+               .sotype = sotype,
+               .reuseport = reuseport_prog,
+       };
+       struct network_helper_opts opts = {
+               .backlog        = SOMAXCONN,
+               .post_socket_cb = setsockopts,
+               .cb_opts        = &cb_opts,
+       };
+       int err, fd;
+
+       fd = start_server_str(cb_opts.family, sotype, ip, port, &opts);
+       if (!ASSERT_GT(fd, 0, "start_server_str"))

ASSERT_G(E). probably helpful to add a new ASSERT_OK_FD into the test_progs.h to 
avoid this in the future.

+               return -1;