From: Geliang Tang <[email protected]>

This patch uses public helper start_server_addr() in udp_recv_send()
in prog_tests/sk_lookup.c to simplify the code.

And use ASSERT_OK_FD() to check fd returned by start_server_addr().

Acked-by: Eduard Zingerman <[email protected]>
Signed-off-by: Geliang Tang <[email protected]>
---
 tools/testing/selftests/bpf/prog_tests/sk_lookup.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c 
b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
index 20ee5da2c721..386e482be617 100644
--- a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
+++ b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
@@ -416,18 +416,12 @@ static int udp_recv_send(int server_fd)
        }
 
        /* Reply from original destination address. */
-       fd = socket(dst_addr->ss_family, SOCK_DGRAM, 0);
-       if (CHECK(fd < 0, "socket", "failed\n")) {
+       fd = start_server_addr(SOCK_DGRAM, dst_addr, sizeof(*dst_addr), NULL);
+       if (!ASSERT_OK_FD(fd, "start_server_addr")) {
                log_err("failed to create tx socket");
                return -1;
        }
 
-       ret = bind(fd, (struct sockaddr *)dst_addr, sizeof(*dst_addr));
-       if (CHECK(ret, "bind", "failed\n")) {
-               log_err("failed to bind tx socket");
-               goto out;
-       }
-
        msg.msg_control = NULL;
        msg.msg_controllen = 0;
        n = sendmsg(fd, &msg, 0);
-- 
2.43.0


Reply via email to