From: Mirsad Todorovac <[email protected]> Date: Mon, 12 Aug 2024 02:22:58 +0200 > GCC 13.2.0 reported warning about (void *) beeing used as a param where (char > *) is expected: > > In file included from msg_oob.c:14: > msg_oob.c: In function ‘__recvpair’: > ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument of > type ‘char *’, > but argument 6 has type > ‘const void *’ [-Wformat=] > 106 | fprintf(TH_LOG_STREAM, "# %s:%d:%s:" fmt "\n", \ > | ^~~~~~~~~~~~~ > ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’ > 101 | __TH_LOG(fmt, ##__VA_ARGS__); \ > | ^~~~~~~~ > msg_oob.c:235:17: note: in expansion of macro ‘TH_LOG’ > 235 | TH_LOG("Expected:%s", expected_errno ? > strerror(expected_errno) : expected_buf); > | ^~~~~~ > ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument of > type ‘char *’, > but argument 6 has type > ‘const void *’ [-Wformat=] > 106 | fprintf(TH_LOG_STREAM, "# %s:%d:%s:" fmt "\n", \ > | ^~~~~~~~~~~~~ > ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’ > 101 | __TH_LOG(fmt, ##__VA_ARGS__); \ > | ^~~~~~~~ > msg_oob.c:259:25: note: in expansion of macro ‘TH_LOG’ > 259 | TH_LOG("Expected:%s", expected_errno ? > strerror(expected_errno) : expected_buf); > | ^~~~~~ > > Casting param to (char *) silences the warning. > > Fixes: d098d77232c37 ("selftest: af_unix: Add msg_oob.c.") > Cc: "David S. Miller" <[email protected]> > Cc: Eric Dumazet <[email protected]> > Cc: Jakub Kicinski <[email protected]> > Cc: Paolo Abeni <[email protected]> > Cc: Shuah Khan <[email protected]> > Cc: Kuniyuki Iwashima <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Mirsad Todorovac <[email protected]>
Thanks for the patch! but I found the same patch posted a bit earlier here, and Abhinav will post v2. https://lore.kernel.org/netdev/[email protected]/
