Change specifier to %p to correctly substitute type 'const void *'. A
specifer involved with a macro is causing a misleading warning to occur:
In file included from msg_oob.c:14:
msg_oob.c: In function ???__recvpair???:
../../kselftest_harness.h:106:40: warning: format ???%s??? expects
argument of type ???char *???, but argument 6 has type
???const void *??? [-Wformat=]
106 | fprintf(TH_LOG_STREAM, "# %s:%d:%s:" fmt "\n", \
| ^~~~~~~~~~~~~
../../kselftest_harness.h:101:17: note: in expansion of macro ???__TH_LOG???
101 | __TH_LOG(fmt, ##__VA_ARGS__); \
| ^~~~~~~~
msg_oob.c:235:17: note: in expansion of macro ???TH_LOG???
235 | TH_LOG("Expected:%s", expected_errno ?
strerror(expected_errno) : expected_buf);
| ^~~~~~
A second set of these three warnings occur later for the incorrect
specifier at msg_oob.c:256. By tracing the various macros involved, the
correct specifier (in msg_oob.c) can be spotted and changed.
Signed-off-by: David Hunter <[email protected]>
---
tools/testing/selftests/net/af_unix/msg_oob.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/af_unix/msg_oob.c
b/tools/testing/selftests/net/af_unix/msg_oob.c
index 16d0c172eaeb..87090ebda2a7 100644
--- a/tools/testing/selftests/net/af_unix/msg_oob.c
+++ b/tools/testing/selftests/net/af_unix/msg_oob.c
@@ -232,7 +232,7 @@ static void __recvpair(struct __test_metadata *_metadata,
if (ret[0] != expected_len || recv_errno[0] != expected_errno) {
TH_LOG("AF_UNIX :%s", ret[0] < 0 ? strerror(recv_errno[0]) :
recv_buf[0]);
- TH_LOG("Expected:%s", expected_errno ? strerror(expected_errno)
: expected_buf);
+ TH_LOG("Expected:%p", expected_errno ? strerror(expected_errno)
: expected_buf);
ASSERT_EQ(ret[0], expected_len);
ASSERT_EQ(recv_errno[0], expected_errno);
@@ -256,7 +256,7 @@ static void __recvpair(struct __test_metadata *_metadata,
cmp = strncmp(expected_buf, recv_buf[0], expected_len);
if (cmp) {
TH_LOG("AF_UNIX :%s", ret[0] < 0 ?
strerror(recv_errno[0]) : recv_buf[0]);
- TH_LOG("Expected:%s", expected_errno ?
strerror(expected_errno) : expected_buf);
+ TH_LOG("Expected:%p", expected_errno ?
strerror(expected_errno) : expected_buf);
ASSERT_EQ(cmp, 0);
}
--
2.43.0
