Check if veth pair was created and if yes, xfail on setting IP address
logging an informational message.
Use XFAIL instead of SKIP for unsupported ethtool APIs.

Signed-off-by: Abhinav Jain <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
---
 tools/testing/selftests/net/netdevice.sh | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/netdevice.sh 
b/tools/testing/selftests/net/netdevice.sh
index f7752e1ebe22..438f7b2acc5f 100755
--- a/tools/testing/selftests/net/netdevice.sh
+++ b/tools/testing/selftests/net/netdevice.sh
@@ -67,8 +67,12 @@ kci_net_setup()
                return $ksft_skip
        fi
 
-       # TODO what ipaddr to set ? DHCP ?
-       echo "SKIP: $netdev: set IP address"
+       if [ "$veth_created" ]; then
+               echo "XFAIL: $netdev: set IP address unsupported for veth*"
+       else
+               # TODO what ipaddr to set ? DHCP ?
+               echo "SKIP: $netdev: set IP address"
+       fi
        return $ksft_skip
 }
 
@@ -86,7 +90,7 @@ kci_netdev_ethtool_test()
        ret=$?
        if [ $ret -ne 0 ];then
                if [ $ret -eq "$1" ];then
-                       echo "SKIP: $netdev: ethtool $2 not supported"
+                       echo "XFAIL: $netdev: ethtool $2 not supported"
                        return $ksft_skip
                else
                        echo "FAIL: $netdev: ethtool $2"
-- 
2.34.1


Reply via email to