Re: [PATCH v5 16/30] arm64: handle PKEY/POE faults

[Mark Brown]

On Thu, Aug 22, 2024 at 04:10:59PM +0100, Joey Gouly wrote:

> +static bool fault_from_pkey(unsigned long esr, struct vm_area_struct *vma,
> +                     unsigned int mm_flags)
> +{
> +     unsigned long iss2 = ESR_ELx_ISS2(esr);
> +
> +     if (!system_supports_poe())
> +             return false;
> +
> +     if (iss2 & ESR_ELx_Overlay)
> +             return true;

Does this need an is_data_abort() && is_instruction_abort() check?
Overlay doesn't appear to be defined for all exception types and it
wasn't clear enough to me that the callers have done this check.

signature.asc
Description: PGP signature