On Fri, Nov 08, 2024 at 03:25:46PM +0000, Catalin Marinas wrote: > On Fri, Nov 08, 2024 at 03:10:59PM +0000, Mark Brown wrote:
> > > - (ret & PR_MTE_TCF_MASK), mask); > > > + (int)(ret & PR_MTE_TCF_MASK), mask); > > Shouldn't we just use a %lx here? Casts tend to be suspicious... > It's more like the ret is actually 32-bit and should stay like that when > bits are masked out. But the bitwise op 'upgrades' it to a long (in > hindsight, we should not have used UL for the TCF bits and mask). Hrm, right. Possibly put the cast on PR_MTE_TCF_MASK rather than on the expression as a whole then?
signature.asc
Description: PGP signature
