On Wed, May 21, 2025 at 03:44:04PM +0800, David Gow wrote: > On Tue, 20 May 2025 at 16:21, Tzung-Bi Shih <[email protected]> wrote: > > > > kunit_deactivate_static_stub() accepts real_fn_addr instead of > > replacement_addr. In the case, it always passes NULL to > > kunit_deactivate_static_stub(). > > > > Fix it. > > > > Fixes: e047c5eaa763 ("kunit: Expose 'static stub' API to redirect > > functions") > > Signed-off-by: Tzung-Bi Shih <[email protected]> > > --- > > Nice catch! I guess no-one's ever tried to pass NULL to deactivate the stub! > > (Maybe we should add a test for this somewhere?)
Added a test for this, https://lore.kernel.org/linux-kselftest/[email protected]/T/#u
