On Sun, 29 Jun 2025 22:49:24 +0000 Chia-Yu Chang (Nokia) wrote: > > I don't get the reason for all these WRITE_ONCE()s. > > You lock the qdisc to make modifications, right? > > And the block under which I'm responding is performing two dependent > > writes, one to ->step_in_packets and the other to ->step_thresh a change > > which is definitely not atomic.. > > Thanks again for other comments again, and I will take actions in the next > version. > > As there is only one step marking in L-queue, so we still need two > WRITE_ONCE even two attributes (one for threshold in packets and one > in time) are used. > > When applying the step marking, we need to know either the > computation is based on the sojourn time or queue length.
Let me ask again - why do you use WRITE_ONCE() at all if the modification takes the qdisc lock? Which reader are you afraid of racing with?
