On 5/14/25 2:00 PM, Randy Dunlap wrote:
>
>
> On 5/14/25 12:24 PM, Sergio González Collado wrote:
>> The kunit test that checks the longests symbol length [1], has triggered
>> warnings in some pilelines when symbol prefixes are used [2][3]. The test
>> will to depend on !PREFIX_SYMBOLS and !CFI_CLANG as sujested in [4] and
>> on !GCOV_KERNEL.
>>
>> [1]
>> https://lore.kernel.org/rust-for-linux/CABVgOSm=5Q0fM6neBhxSbOUHBgNzmwf2V22vsYC10YRBT=k...@mail.gmail.com/T/#t
>> [2] https://lore.kernel.org/all/[email protected]/T/#u
>> [3]
>> https://lore.kernel.org/rust-for-linux/[email protected]/T/#t
>> [4]
>> https://lore.kernel.org/linux-kselftest/20250427200916.GA1661412@ax162/T/#t
>>
>> Reviewed-by: Rae Moar <[email protected]>
>> Signed-off-by: Sergio González Collado <[email protected]>
>
>
> Works for me. Thanks.
>
> Acked-by: Randy Dunlap <[email protected]>
> Tested-by: Randy Dunlap <[email protected]>
>
>
>> ---
>> v2 -> v3: added dependency on !GCOV_KERNEL (to avoid __gcov_ prefix)
>> ---
>> v1 -> v2: added dependency on !CFI_CLANG as suggested in [3], removed
>> CONFIG_ prefix
>> ---
>> lib/Kconfig.debug | 1 +
>> lib/tests/longest_symbol_kunit.c | 3 +--
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index f9051ab610d5..e55c761eae20 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -2886,6 +2886,7 @@ config FORTIFY_KUNIT_TEST
>> config LONGEST_SYM_KUNIT_TEST
>> tristate "Test the longest symbol possible" if !KUNIT_ALL_TESTS
>> depends on KUNIT && KPROBES
>> + depends on !PREFIX_SYMBOLS && !CFI_CLANG && !GCOV_KERNEL
>> default KUNIT_ALL_TESTS
>> help
>> Tests the longest symbol possible
>> diff --git a/lib/tests/longest_symbol_kunit.c
>> b/lib/tests/longest_symbol_kunit.c
>> index e3c28ff1807f..9b4de3050ba7 100644
>> --- a/lib/tests/longest_symbol_kunit.c
>> +++ b/lib/tests/longest_symbol_kunit.c
>> @@ -3,8 +3,7 @@
>> * Test the longest symbol length. Execute with:
>> * ./tools/testing/kunit/kunit.py run longest-symbol
>> * --arch=x86_64 --kconfig_add CONFIG_KPROBES=y --kconfig_add
>> CONFIG_MODULES=y
>> - * --kconfig_add CONFIG_RETPOLINE=n --kconfig_add CONFIG_CFI_CLANG=n
>> - * --kconfig_add CONFIG_MITIGATION_RETPOLINE=n
>> + * --kconfig_add CONFIG_CPU_MITIGATIONS=n --kconfig_add
>> CONFIG_GCOV_KERNEL=n
>> */
>>
>> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>>
>> base-commit: 1a80a098c606b285fb0a13aa992af4f86da1ff06
>
Hi,
I'm still seeing this issue in linux-next 20250703.
Any merge plans for this patch?
Thanks.
--
~Randy
