On Tue, Sep 02, 2025 at 11:55:04PM +0000, Marc Harvey wrote: > There are currently no kernel tests that verify setting and getting > options of the team driver. > > In the future, options may be added that implicitly change other > options, which will make it useful to have tests like these that show > nothing breaks. There will be a follow up patch to this that adds new > "rx_enabled" and "tx_enabled" options, which will implicitly affect the > "enabled" option value and vice versa. > > The tests use teamnl to first set options to specific values and then > gets them to compare to the set values. > > Signed-off-by: Marc Harvey <marchar...@google.com> > --- > .../selftests/drivers/net/team/Makefile | 6 +- > .../selftests/drivers/net/team/options.sh | 194 ++++++++++++++++++ > 2 files changed, 198 insertions(+), 2 deletions(-) > create mode 100755 tools/testing/selftests/drivers/net/team/options.sh > > diff --git a/tools/testing/selftests/drivers/net/team/Makefile > b/tools/testing/selftests/drivers/net/team/Makefile > index eaf6938f100e..8b00b70ce67f 100644 > --- a/tools/testing/selftests/drivers/net/team/Makefile > +++ b/tools/testing/selftests/drivers/net/team/Makefile > @@ -1,11 +1,13 @@ > # SPDX-License-Identifier: GPL-2.0 > # Makefile for net selftests > > -TEST_PROGS := dev_addr_lists.sh propagation.sh > +TEST_PROGS := dev_addr_lists.sh propagation.sh options.sh > > TEST_INCLUDES := \ > ../bonding/lag_lib.sh \ > ../../../net/forwarding/lib.sh \ > - ../../../net/lib.sh > + ../../../net/lib.sh \ > + ../../../net/in_netns.sh \
I didn't find you use namespace for testing, so why include the in_netns.sh ? BTW, It's recommended to use namespace for testing to avoid affect the main net. Thanks Hangbin
