On Sun, 15 Feb 2026 14:51:49 +0200 Gal Pressman wrote: > The cited commit refactored the hardcoded timeout=5 into a parameter, > but dropped the keyword from the communicate() call. > Since Popen.communicate()'s first positional argument is 'input' (not > 'timeout'), the timeout value is silently treated as stdin input and the > call never enforces a timeout. > > Pass timeout as a keyword argument to restore the intended behavior.
Makes sense, but looks like tools/testing/selftests/drivers/net/netpoll_basic.py fails now: https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-drv/results/519460/3-netpoll-basic-py/stdout I think bpftrace() needs to pass the timeout to cmd(). Probably something like the timeout param that it's passed + 5 sec? -- pw-bot: cr
