On 06/03/2026 22:01, Jakub Kicinski wrote:
On Thu, 5 Mar 2026 00:06:23 +0100 Antonio Quartulli wrote:
+def check_requirements(requirements_path):
+ """Return dependency issues from requirements_path, or an empty list."""
+ issues = []
+ with open(requirements_path, encoding="utf-8") as f:
Semi-jokingly let me also mention that you do all this requirements
checking here, all the dependencies seem to have been installed on
netdev CI already.
as expected :-)
One thing for which you don't check is ngrep,
and that was not installed.
yeah, because the script is only checking the python deps.
IMO the requirements checking is a waste of effort, things always
slip thru.
I am fine with dropping the dep check if you also don't find it of much
value.
We'd have to keep it updated and it won't help much once packages have
been installed the first time.
But unless you have a strong reason to use ngrep maybe
switch to a more standard tool?
Any recommendation?
ngrep is used to make sure that received packets start with a specific
pattern (OpenVPN header with certain values in it).
I presume we can just replace ngrep with tcpdump, assuming it's "more
standard".
Regards,
--
Antonio Quartulli
OpenVPN Inc.
