Stanislav Fomichev wrote: > On 04/01, Jakub Kicinski wrote: > > Sometimes it's hard to spot the ok / not ok lines in the output. > > This is especially true for the GRO tests which retries a lot > > so there's a wall of non-fatal output printed. > > > > Try to color the crucial lines green / red / yellow when running > > in a terminal. > > > > Signed-off-by: Jakub Kicinski <[email protected]> > > --- > > This is a bit of RFC, I'm not super convinced this is worth > > carrying in the tree? Please Ack/Review I'll apply if we get > > 3 supporting tags. > > Acked-by: Stanislav Fomichev <[email protected]>
Reviewed-by: Willem de Bruijn <[email protected]> Minor aside: I don't know exactly how to exhaustively test whether a terminal supports colors. If unsure, an inverse approach to err on the side of caution may be safer. But overall +1 on the intent.
