On Thu, 2026-04-02 at 13:44 +0200, Sabrina Dubroca wrote: > 2026-04-02, 14:10:30 +0300, Cosmin Ratiu wrote: > > This short series adds support for VLANs in MACsec devices when > > offload > > mode is enabled. This allows VLAN netdevs on top of MACsec netdevs > > to > > function, which accidentally used to be the case in the past, but > > was > > broken. This series adds back proper support. > > > > As part of this, the existing nsim-only MACsec offload tests were > > translated to Python so they can run against real HW and new > > traffic-based tests were added for VLAN filter propagation, since > > there's currently no uAPI to check VLAN filters. > > > > --- > > > > V7: > > - Added missing ethtool feature checks. > > Sorry that I couldn't get to your patches earlier (-EBUSY, > progressing > toward -ENOTRECOVERABLE), but please don't rush to repost while I was > still going through what you had already posted. >
Apologies, I thought you are done with the review and just wanted to get this done with. I'll address your comments in v8... Cosmin.
