On Wed, 6 May 2026 17:32:10 +0200 Paolo Abeni wrote: > On 5/6/26 5:22 PM, Paolo Abeni wrote: > > On 5/6/26 2:06 AM, Jakub Kicinski wrote: > >> net_shaper_commit() overrides nodes which may be concurrently read > >> under RCU. This is not a huge deal since the entries only contain > >> config, worst case user will see inconsistent config params. But > >> we should try to avoid this obvious RCU violation. Try to allocate > >> a new node. Since commit() can't fail fall back to overriding. > >> > >> Full fix is probably not worth the complexity, struct net_shaper > >> is around 80B, and the allocation is with GFP_KERNEL. > > > > I'm not sure if even this variant is worthy?!? The scheduler tree dump > > could be still inconsistent, as the dump is not atomic. IMHO e.g. > > inconsistent weights in the same WRR group would be as bad as > > inconsistent values inside the single shaper. > > I mean: I would simply avoid addressing this RCU violation.
Alright. I'll add a comment instead (fix just the ordering WRT to the VALID flag)
