> -----Original Message-----
> From: Simon Horman <[email protected]>
> Subject: RE: [EXTERNAL] [PATCH v2 net-next 5/8] net: ena: PHC: Check return
> code before setting timestamp output
>
> On Thu, Apr 30, 2026 at 03:25:02AM +0000, Arthur Kiyanovski wrote:
> > ena_phc_gettimex64() is setting the output parameter regardless of
> > whether ena_com_phc_get_timestamp() succeeded or failed.
> >
> > When ena_com_phc_get_timestamp() returns an error, the timestamp
> > parameter may contain uninitialized stack memory (e.g., when PHC is
> > disabled or in blocked state) or invalid hardware values. Passing
> > these to userspace via the PTP ioctl is both a security issue
> > (information leak) and a correctness bug.
> >
> > Fix by checking the return code after releasing the lock and only
> > setting the output timestamp on success.
> >
> > Fixes: e0ea34158ee8 ("net: ena: Add PHC support in the ENA driver")
> > Signed-off-by: Arthur Kiyanovski <[email protected]>
>
> Hi Arthur,
>
> Perhaps I am missing a dependency, but it seems to me that it would be best
> to separate this patch from the rest of this patch-set and post it a fix
> targeted
> at net, CCed to stable.
Thank you Simon,
I resent it to net separately.
Thank you,
Arthur
