Sean Christopherson <[email protected]> writes: > > [...snip...] > > --- virt/kvm/guest_memfd.c > +++ virt/kvm/guest_memfd.c > @@ -640,9 +640,9 @@ int kvm_gmem_create(struct kvm *kvm, struct > kvm_create_guest_memfd *args) > } > > int kvm_gmem_bind(struct kvm *kvm, struct kvm_memory_slot *slot, > - unsigned int fd, loff_t offset) > + unsigned int fd, u64 offset) > { > - loff_t size = slot->npages << PAGE_SHIFT; > + u64 size = slot->npages << PAGE_SHIFT; > unsigned long start, end; > struct gmem_file *f; > struct inode *inode; >
My mental model was: + offsets => loff_t + indices => pgoff_t + sizes => size_t But looks like loff_t is more suitable for places where return values (possibly negative) matter. Good to go with u64! > [...snip...] >
